Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unmanaged dependencies are not included in the WAR #189

Closed
He-Pin opened this issue Sep 23, 2013 · 12 comments
Closed

Unmanaged dependencies are not included in the WAR #189

He-Pin opened this issue Sep 23, 2013 · 12 comments
Assignees
@dlecan
Labels
bug plugin
Milestone
v1.1.1

Comments

@He-Pin
Copy link

He-Pin commented Sep 23, 2013

Hi,thanks for your great work
If I have an dependency jar in /lib then when I run play war
the jar file is not include in the built war.
which means that there is no jar which i put in the /lib in the
/WEB-INF/lib
@He-Pin
Copy link
Author

He-Pin commented Sep 23, 2013

fixd via
Embed custom WAR configuration files in WIKI
but i think your may provide an better way

@ghost ghost assigned dlecan Sep 23, 2013
@dlecan
Copy link
Member

dlecan commented Sep 24, 2013

That's a regression introduced by fix for #173.

@He-Pin
Copy link
Author

He-Pin commented Sep 25, 2013

thanks
I just add the file duplicated just as your wiki says

@He-Pin He-Pin closed this as completed Sep 25, 2013
@dlecan
Copy link
Member

dlecan commented Sep 25, 2013

Don't close this issue, it's not fixed :)

@dlecan dlecan reopened this Sep 25, 2013
@dlecan dlecan closed this as completed in 1376a8b Sep 25, 2013
dlecan added a commit that referenced this issue Sep 25, 2013
@dlecan
Fix #189: re-add unmanaged dependencies in WAR
7f76d45
@dlecan
Copy link
Member

dlecan commented Sep 25, 2013

Which version of Play2War are you using ?

@He-Pin
Copy link
Author

He-Pin commented Sep 26, 2013

version 1.1

@dlecan
Copy link
Member

dlecan commented Sep 26, 2013

Ok, I will release Play2War v1.1.1 which fixes this issue.

dlecan added a commit that referenced this issue Sep 26, 2013
@dlecan
Fix #189: re-add unmanaged dependencies in WAR
cbc0096
@He-Pin
Copy link
Author

He-Pin commented Sep 27, 2013

I will test it now

@He-Pin
Copy link
Author

He-Pin commented Sep 27, 2013

:: com.github.play2war#play2-war-plugin;1.1.1: not found
@dlecan

@dlecan
Copy link
Member

dlecan commented Sep 27, 2013

@hepin1989 no released yet

@dlecan
Copy link
Member

dlecan commented Sep 30, 2013

Play2War 1.1.1 has been released !

@He-Pin
Copy link
Author

He-Pin commented Oct 1, 2013

thanks I will take it a try

何品

On Tue, Oct 1, 2013 at 3:47 AM, Damien Lecan [email protected]:

Play2War 1.1.1 has been released !

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/189#issuecomment-25398135
.

@dlecan dlecan mentioned this issue Dec 26, 2013
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dlecan dlecan

Labels
bug plugin
Projects
None yet
Milestone
v1.1.1
Development

No branches or pull requests
2 participants
@He-Pin @dlecan