Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace Bintray with Sonatype via sbt-ci-release #603

Merged
merged 3 commits into from
May 5, 2021
Merged

replace Bintray with Sonatype via sbt-ci-release #603

merged 3 commits into from
May 5, 2021

Conversation

SethTisue
Copy link
Member

@SethTisue SethTisue commented Apr 21, 2021 •
edited
Loading

references #600
references #578

@SethTisue
Copy link
Member Author

I'll resume work on this in a few days

@SethTisue SethTisue mentioned this pull request Apr 21, 2021
Closed
@SethTisue SethTisue self-assigned this Apr 21, 2021
@SethTisue
Copy link
Member Author

SethTisue commented Apr 29, 2021 •
edited
Loading

To help test this PR before merging it, it currently has (branch = main AND type = push) OR (tag IS present). But I intend to cut that back to just tag IS present since (to my knowledge) nobody is asking for snapshots.

in the release job at https://travis-ci.com/github/playframework/play-json/jobs/502063131 it says No access to secret variables, doing nothing as expected, since we haven't added the secrets yet.

So I suggest we go ahead and merge this, though it remains possible that we'll find out when we actually tag a release that further adjustments will be necessary.

@SethTisue
disable snapshot publishing
c0b585c 
not that I'd be opposed, but nobody has asked for it
@SethTisue SethTisue marked this pull request as ready for review April 29, 2021 19:22
@SethTisue
Copy link
Member Author

@ennru can you add the necessary secrets to the repo?

@SethTisue SethTisue removed their assignment May 3, 2021
@SethTisue SethTisue merged commit e829bb8 into playframework:main May 5, 2021
@SethTisue SethTisue deleted the sbt-ci-release branch May 5, 2021 14:18
@SethTisue
Copy link
Member Author

@ennru ping

@SethTisue SethTisue mentioned this pull request May 5, 2021
Closed
@octonato
Copy link
Contributor

octonato commented May 5, 2021

@SethTisue, I will add the credentials

@octonato
Copy link
Contributor

octonato commented May 5, 2021

Secrets are added.

I agree that nobody is ask for snapshots. Until someone asks. ;-)

On the other hand, we can always create snapshot'ish tags (2.10.0-adfwe23 or 2.10.0-beta1) when someone needs something.

This was referenced Jul 15, 2021
Closed
Closed
SethTisue added a commit to SethTisue/cachecontrol that referenced this pull request Jul 22, 2021
@SethTisue
add Sonatype-based publishing
c76595d 
modeled after playframework/play-json#603
SethTisue added a commit to SethTisue/cachecontrol that referenced this pull request Jul 22, 2021
@SethTisue
add Sonatype-based publishing
13c15a3 
modeled after playframework/play-json#603
@SethTisue SethTisue mentioned this pull request Jul 22, 2021
Merged
SethTisue added a commit to SethTisue/twirl that referenced this pull request Jul 28, 2021
@SethTisue
publishing: bye Bintray, hello Sonatype
a91550a 
modeled after playframework/play-json#603
@SethTisue SethTisue mentioned this pull request Jul 28, 2021
Merged
SethTisue added a commit to SethTisue/twirl that referenced this pull request Jul 28, 2021
@SethTisue
publishing: bye Bintray, hello Sonatype
ae8b3a7 
modeled after playframework/play-json#603
SethTisue added a commit to SethTisue/twirl that referenced this pull request Jul 28, 2021
@SethTisue
publishing: bye Bintray, hello Sonatype
86fdabe 
modeled after playframework/play-json#603
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SethTisue @octonato