Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scala 2.13.8 #694

Merged
merged 2 commits into from
Jan 12, 2022
Merged

Scala 2.13.8 #694

merged 2 commits into from
Jan 12, 2022

Conversation

mkurz
Copy link
Member

@mkurz mkurz commented Jan 11, 2022

Let's see if Travis still kicks in...

@ihostage
Copy link
Member

Someone should remove a Travis CI check for this repo 😄

@mkurz
Copy link
Member Author

mkurz commented Jan 11, 2022

Someone should remove a Travis CI check for this repo smile

Yes I am working on that. I was not sure what to disable. I thought maybe removing the .travis.yml is enough. Also I disabled


in https://app.travis-ci.com/github/playframework/play-json/settings
Plus I removed a webhook configured in this GitHub repo.

However it seems I have to disable the Travis integration for this repositoy, which means I have to select all repositories except play-json, which is a bit painful:


@mkurz mkurz mentioned this pull request Jan 11, 2022
@mkurz mkurz closed this Jan 11, 2022
@mkurz mkurz reopened this Jan 11, 2022
@mkurz mkurz enabled auto-merge January 11, 2022 11:45
@ihostage
Copy link
Member

However it seems I have to disable the Travis integration for this repositoy, which means I have to select all repositories except play-json, which is a bit painful:

Yes. And as I progress by migration from Travis to GA, you will need to remove other repositories one by one. 😄

@mkurz
Copy link
Member Author

mkurz commented Jan 11, 2022

OK, Travis removed. Finally I found the correct way, using branch protection rules for this repos:

There you modify the checks which are required...

@mkurz
Copy link
Member Author

mkurz commented Jan 11, 2022

Blocked by ghik/silencer#71

@mkurz
Copy link
Member Author

mkurz commented Jan 12, 2022

@mkurz
Copy link
Member Author

mkurz commented Jan 12, 2022

@ihostage If you approve it should get merged automatically (I can not approve my own PRs)

@mkurz mkurz merged commit 94fe347 into main Jan 12, 2022
@mergify mergify bot deleted the scala_2.13.8 branch January 12, 2022 07:19
@ihostage
Copy link
Member

@mkurz done 😉

@mkurz
Copy link
Member Author

mkurz commented Jan 12, 2022

Actually here the GitHub "merge automatically" feature was faster than mergify. Interestingly it says "mkurz merged..." but I didn't merge manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants