Introduce configurable congestion control. #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The primary motivation for this (as of 2024/02/28) is increase availability for customers using PlayHT On-Prem appliance by adding quick retries in response to RESOURCE_EXHAUSTED errors.
This change allows customers to turn on one of an enumerated set of congestion control algorithms. We've implemented just one for now, STATIC_MAR_2024, which retries at most twice with a 50ms backoff between attempts. This is a dead simple congestion control algorithm with static constants; it leaves a lot to be desired. We should iterate on these algorithms in the future. The CongestionCtrl enum was added so that algorithms can be added without requiring customers to change their code much.
NCarrollPlay
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The primary motivation for this (as of 2024/02/28) is increase availability for customers using PlayHT On-Prem appliance by adding quick retries in response to RESOURCE_EXHAUSTED errors.
This change allows customers to turn on one of an enumerated set of congestion control algorithms. We've implemented just one for now, STATIC_MAR_2024, which retries at most twice with a 50ms backoff between attempts. This is a dead simple congestion control algorithm with static constants; it leaves a lot to be desired. We should iterate on these algorithms in the future. The CongestionCtrl enum was added so that algorithms can be added without requiring customers to change their code much.
See the analogous change in the NodeJs SDK here: playht/playht-nodejs-sdk#31