Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make all non-upstream functions private #72

Closed
SaadBazaz opened this issue May 16, 2024 · 3 comments
Closed

Make all non-upstream functions private #72

SaadBazaz opened this issue May 16, 2024 · 3 comments
Assignees
@momintlh
Labels
bug Something isn't working

Comments

@SaadBazaz
Copy link
Collaborator

SaadBazaz commented May 16, 2024 •
edited
Loading

What happened?

hey, I just figure out that there is a GetPlayerState in the Player class. How is it different from GetState?

Possible solution

Any function which isn't in PlayroomKit JS SDK, should be private in Unity SDK. So we have complete feature parity.

Version

0.0.22

What is your environment?

Unknown

Link to original discussion

https://discord.com/channels/997752993598419044/1128151935669764096/1240665682782453825
Related: https://discord.com/channels/997752993598419044/1128151935669764096/1240729357513916416

Relevant log output

image
@SaadBazaz SaadBazaz added the bug Something isn't working label May 16, 2024
@SaadBazaz SaadBazaz assigned SaadBazaz and momintlh and unassigned SaadBazaz May 16, 2024
@SaadBazaz
Copy link
Collaborator Author

You might also want to read this thread, @momintlh :
https://discord.com/channels/997752993598419044/1128151935669764096/1240729357513916416

This developer has a lot of good points. We can clean up our implementation better, and make the DX cleaner for developers.

Tagging #40 as it seems related.

@momintlh
Copy link
Collaborator

Will fix this today.

momintlh added a commit that referenced this issue May 17, 2024
@momintlh
fix: made internal functions private.
647af7b 
* Made all non-upstream functions private #72
* Removed unnecessary warning log
@momintlh momintlh mentioned this issue May 17, 2024
Merged
@SaadBazaz
Copy link
Collaborator Author

Solved in #73 , released in v0.0.23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@momintlh momintlh

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SaadBazaz @momintlh