Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: GetStateString. #42

Merged
merged 2 commits into from
Feb 4, 2024
Merged

Fixed: GetStateString. #42

merged 2 commits into from
Feb 4, 2024

Conversation

momintlh
Copy link
Collaborator

@momintlh momintlh commented Feb 1, 2024

  • Fixed GetStateString, now null / empty strings are working, no more conversion error. based on Errors piping to c# #38

Copy link
Collaborator

@SaadBazaz SaadBazaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes half of #38 . The other half is adding the try-catch and piping the errors anyway, so we can have more visibility into the error, and devs can report things to us better.

@momintlh momintlh requested a review from SaadBazaz February 2, 2024 14:31
Copy link
Collaborator

@SaadBazaz SaadBazaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need clarification:
Currently, you've try-catched just one function. Can we have a try-catch over all Playroom JSLib activities? And then pipe the error to Unity as we discussed?

If you have a better plan for it, you can also drop a comment in #40 which explains how you plan to tackle this in future PRs.

@SaadBazaz
Copy link
Collaborator

Merging this, because future documentation can be done in #40 .

@SaadBazaz SaadBazaz merged commit eefaf86 into main Feb 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants