RPC API

[momintlh]

Changes:

• Added RPCRegister
• Added RPCCall
• Added enum for RPC Modes in Unity.

Next Tasks:

• Currently only String data can be passed, maybe giving a helper function to convert data to JSON?
• Callback in RPCregister from Unity.
• List Of Callbacks
• Parsing data and sender
• Clean-Up

Testing:

Verified the changes by testing RPC registrations and calls with different modes from both C# and JavaScript. Checked the sequence of ENUM values and ensured correct callback invocations.

Test Results:

• Host registers and gets the following response:
  

Rock is the data passed by sender / the nonhost player in this case.

• Nonhost player calls:
  

here response (Okay!) is being received from the register callback

based on #37

---

Final demo output: https://mmntlh.itch.io/playroom-demo

[SaadBazaz]

Needs clarification.

[momintlh]

The issue where callback was getting overridden is fixed, so now each RPC event can call its own callback, but when the same event has different callbacks, only the latest one gets invoked. Current solution I have is to change the Dictionary<string, Action> to Dictionary<string, List<Action>>, so each event can hold multiple callbacks, But I might be Overengineering this part, so any suggestions would be helpful. @SaadBazaz @asadm.

Changes are in this commit: c60dc8d

[SaadBazaz]

The issue where callback was getting overridden is fixed, so now each RPC event can call its own callback, but when the same event has different callbacks, only the latest one gets invoked. Current solution I have is to change the Dictionary<string, Action> to Dictionary<string, List<Action>>, so each event can hold multiple callbacks, But I might be Overengineering this part, so any suggestions would be helpful. @SaadBazaz @asadm.

Changes are in this commit: c60dc8d

I think your approach is fine. Do you have any other solutions in mind?

[momintlh]

 RpcRegister: function (name) {
    if (!window.Playroom) {
      console.error("Playroom library is not loaded. Please make sure to call InsertCoin first.");
      return;
    }

    function registerCallback(data, sender) {
      //TODO: callback from unity here?  dynCall('vi', callback, [data, sender])
      console.log(`${sender.id} played their turn!`);
      console.log(`recieving: ${data}`);
      return 'okay!';
    }

    // Register the callback for the RPC
    Playroom.RPC.register(UTF8ToString(name), registerCallback);
  },

I believe the (data, sender) should be accessible from with unity, right? for that I can have a dynCall() within registerCallback and pass the data, sender as arguments, to do something after the rpcCall has invoked its callback.
(will need to serialize both data and sender before passing as well.)

^ is this the correct architecture here? @SaadBazaz

[SaadBazaz]

 RpcRegister: function (name) {
    if (!window.Playroom) {
      console.error("Playroom library is not loaded. Please make sure to call InsertCoin first.");
      return;
    }

    function registerCallback(data, sender) {
      //TODO: callback from unity here?  dynCall('vi', callback, [data, sender])
      console.log(`${sender.id} played their turn!`);
      console.log(`recieving: ${data}`);
      return 'okay!';
    }

    // Register the callback for the RPC
    Playroom.RPC.register(UTF8ToString(name), registerCallback);
  },

I believe the (data, sender) should be accessible from with unity, right? for that I can have a dynCall() within registerCallback and pass the data, sender as arguments, to do something after the rpcCall has invoked its callback. (will need to serialize both data and sender before passing as well.)

^ is this the correct architecture here? @SaadBazaz

Looks about right, what if we need multiple? 😬 Does the PlayroomKit JS support multiple callbacks?

[asadm]

multiple callbacks for one rpc? yes.

[momintlh]

DEMO game: https://mmntlh.itch.io/playroom-demo

Score (UI) is updated using RPC now. I tried using rpc for syncing movement (instead of using get/set state) but it was super laggy.

[SaadBazaz]

Approved with comments.

[SaadBazaz]

Can you drop an explainer why this is necessary? Why can't we support these types?