Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zce Branch: BEQI and BNEI wrong encoding #34

Closed
abukharmeh opened this issue Dec 21, 2021 · 4 comments
Closed

Zce Branch: BEQI and BNEI wrong encoding #34

abukharmeh opened this issue Dec 21, 2021 · 4 comments

Comments

@abukharmeh
Copy link

Hi

It appears that BEQI and BNEI are encoded as they were in 0.40.1. In release 0.50.1, we compare against rs2 instead of rs1, and the immediate location was swapped around

This was changed in this commit, riscvarchive/riscv-code-size-reduction@4838a09

Could you please update this to match 0.50.1

Thank you,
Ibrahim

@ChunyuLiao
Copy link
Collaborator

ok, ,thanks , we will fix it

@luke957
Copy link
Contributor

luke957 commented Dec 30, 2021

Hi, we have updated the repo to fix the encoding for beqi and bnei. Also we have added a mi pass to improve instruction compressing. Changes on branch riscv-zce-extension have also been cherry-picked to riscv-zce-llvm14. So it is suggested to try the branch riscv-zce-llvm14.

@Xinlong-Wu
Copy link
Collaborator

I think we have solved the problem, so I am going to close this issue. if there is still a problem, please reopen it

@abukharmeh
Copy link
Author

abukharmeh commented Jan 18, 2022

Sorry for late reply, I can confirm that both issues appear to be fixed , thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants