Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zce Branch: BEQI and BNEI should not be inferred when Immediate is 0 #33

Closed
abukharmeh opened this issue Dec 20, 2021 · 3 comments
Closed

Zce Branch: BEQI and BNEI should not be inferred when Immediate is 0 #33

abukharmeh opened this issue Dec 20, 2021 · 3 comments

Comments

@abukharmeh
Copy link

BEQI and BNEI should not be inferred when the Immediate is 0, since we could already use c.beqz and c.bnez (16 bit instructions).
@abukharmeh abukharmeh changed the title BEQI and BNEI should not be inferred when Immediate is 0 ZCE: BEQI and BNEI should not be inferred when Immediate is 0 Dec 20, 2021
@abukharmeh abukharmeh changed the title ZCE: BEQI and BNEI should not be inferred when Immediate is 0 Zce Branch: BEQI and BNEI should not be inferred when Immediate is 0 Dec 20, 2021
@ChunyuLiao
Copy link
Collaborator

commit should fix this problem. you can try again.

@abukharmeh
Copy link
Author

Hi @ChunyuLiao,

Thank you for fixing this one.

I was checking this against our proof of concept core, and noticed that the encoding is not matching the 0.50.1 release, so I could not check that everything is completely correct until #34 is also fixed.

Kind regards,
Ibrahim.

@PPParticle PPParticle mentioned this issue Jan 11, 2022
Open
@Xinlong-Wu
Copy link
Collaborator

I think we have solved the problem, so I am going to close this issue. if there is still a problem, please reopen it

melonedo pushed a commit to melonedo/llvm-project that referenced this issue Apr 10, 2023
@realqhc
[RISCV] Update MAC instructions (plctlab#33)
4c3dc69 
Updated MAC instructions for CV32E40P from version 1 to version 2 according to the documentation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@abukharmeh @ChunyuLiao @Xinlong-Wu