Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP][OSPP] Add a new test flamework for libcxx-simd #46

Merged
merged 23 commits into from
Oct 31, 2022
Merged

[WIP][OSPP] Add a new test flamework for libcxx-simd #46

merged 23 commits into from
Oct 31, 2022

Conversation

fepicture
Copy link

This pr is a draft pr, I will push the latest progress in this pr.
Any review for code or typos is welcome.
Reference: https://summer-ospp.ac.cn/#/org/prodetail/228d90280

@lazyparser lazyparser requested a review from joy2myself July 21, 2022 07:41
@joy2myself joy2myself mentioned this pull request Aug 4, 2022
Closed
@fepicture fepicture marked this pull request as ready for review August 4, 2022 10:29
@fepicture fepicture force-pushed the libcxx-simd-dev branch 2 times, most recently from ff0421f to cbf199e Compare August 11, 2022 07:49
@fepicture fepicture marked this pull request as draft August 15, 2022 03:17
@fepicture fepicture force-pushed the libcxx-simd-dev branch 2 times, most recently from fb13482 to 0404b17 Compare September 8, 2022 11:01
@fepicture fepicture changed the base branch from libcxx-simd-dev to simd_for_upstream September 8, 2022 11:24
@fepicture fepicture force-pushed the libcxx-simd-dev branch 4 times, most recently from fe68822 to ab85e2d Compare September 8, 2022 12:54
@fepicture fepicture force-pushed the libcxx-simd-dev branch 2 times, most recently from 458dd38 to 9bc59c6 Compare September 26, 2022 01:18
@fepicture fepicture marked this pull request as ready for review October 25, 2022 02:14
joy2myself
joy2myself reviewed Oct 31, 2022
View reviewed changes
libcxx/.clang-format Outdated
@@ -85,4 +85,4 @@ ReflowComments: false
IndentPPDirectives: AfterHash

# libc++ has some long names so we need more than the 80 column limit imposed by LLVM style, for sensible formatting
ColumnLimit: 120
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why, but there seems to be an unwanted diff here

libcxx/test/std/experimental/simd/simd.casts/concat.pass.cpp Outdated Show resolved Hide resolved
libcxx/test/std/experimental/simd/simd.casts/concat.pass.cpp Outdated Show resolved Hide resolved
libcxx/test/std/experimental/simd/simd.casts/concat.pass.cpp Show resolved Hide resolved
libcxx/test/std/experimental/simd/simd.casts/concat.pass.cpp
sub_simd_mask[i] = static_cast<bool>(i);
}
}
auto res = ex::concat<_Tp, SimdAbi, _Np>(arr);

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above.

libcxx/test/std/experimental/simd/simd.nonmembers/simd_alg.pass.cpp Outdated Show resolved Hide resolved
libcxx/test/std/experimental/simd/simd.nonmembers/simd_binary.pass.cpp Outdated Show resolved Hide resolved
libcxx/test/std/experimental/simd/simd.nonmembers/simd_binary.pass.cpp Outdated Show resolved Hide resolved
libcxx/test/std/experimental/simd/simd.nonmembers/simd_reductions.pass.cpp
if constexpr (!std::is_floating_point_v<_Tp>) // ex::reduce has not finish?
{
const ex::simd<_Tp, SimdAbi> simd_([](_Tp i) { return i; });
auto reduce_result = ex::reduce(ex::where(simd_ > 0, simd_), std::multiplies<>());
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing two types of reduce function check for multiplies, bit_and, bit_or, bit_xor.

libcxx/test/std/experimental/simd/simd.nonmembers/simd_reductions.pass.cpp Outdated Show resolved Hide resolved
@joy2myself
Copy link
Collaborator

Please check all the tests to ensure:

  1. Use auto key word to declaration result of all the interfaces.
  2. Use is_same_v to check all the result types.
  3. Use assert_simd_value_correct to check the result values if it is a simd/simd_mask type.

fepicture and others added 5 commits October 31, 2022 18:23
@fepicture
[simd][wip] simd_cast && static_cast lackof
19c5040
@fepicture
[simd] lack of
f7d6549 
* (static )simd cast
* concat split
* simd mask binary
* simd mask where
* simd reduction
* simd unary
@joy2myself @fepicture
[simd] Fixed .clang-format file
04e8238
@fepicture
[simd] wip
13cca1c
@fepicture
[simd] fix mask_where
7987949
@joy2myself joy2myself changed the base branch from simd_for_upstream to simd_test_framework October 31, 2022 14:18
@joy2myself joy2myself merged commit 5e5cd2e into plctlab:simd_test_framework Oct 31, 2022
@PPParticle PPParticle mentioned this pull request Nov 22, 2022
Open
melonedo added a commit to melonedo/llvm-project that referenced this pull request Apr 10, 2023
@melonedo
[RISCV] Support CoreV SIMD intrinsics (plctlab#46)
431b5bd 
Co-authored-by: melonedo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joy2myself joy2myself joy2myself left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fepicture @joy2myself