Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🔧 Fixing env variable. #305

Merged
merged 8 commits into from
Feb 8, 2023
Merged

fix: 🔧 Fixing env variable. #305

merged 8 commits into from
Feb 8, 2023

Conversation

whizzzkid
Copy link
Collaborator

@whizzzkid whizzzkid requested a review from SgtPooki February 8, 2023 03:52
@vercel
Copy link

vercel bot commented Feb 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
starmaps ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 8, 2023 at 5:26AM (UTC)

@whizzzkid
Copy link
Collaborator Author

whizzzkid commented Feb 8, 2023

@SgtPooki So it looks like pull_request_target was the wrong key, their documentation is not super clear. It only seems to be running from the target branch.

This test should've broken before merge, but it did not. SW seems to mess up playwright. I added a step to skip that NO_SW=true

This might have to be overridden, to merge so that this rule changes on main and this error will go away from the next PR onwards.

Apologies for the inconvenience caused. 🙏🏽

@whizzzkid whizzzkid marked this pull request as ready for review February 8, 2023 05:31
@@ -2,9 +2,11 @@ name: CI

on:
push:
branches: [ "main" ]
pull_request_target:
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was the culprit.

Copy link
Contributor

@SgtPooki SgtPooki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor

package.json Show resolved Hide resolved
@whizzzkid whizzzkid merged commit 0ce735c into main Feb 8, 2023
@whizzzkid whizzzkid deleted the fix/ci-test branch February 8, 2023 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants