Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version compare #126

Merged
merged 2 commits into from
Nov 18, 2019
Merged

Fix version compare #126

merged 2 commits into from
Nov 18, 2019

Conversation

stevepiercy
Copy link
Contributor

This PR fixes the following error message.

TASK [Fail if Ansible is old] *****************************************************************************************************************************************************************************************************************************************
fatal: [example.com]: FAILED! => {"msg": "The conditional check 'ansible_version is version('2.5.0', 'lt')' failed. The error was: Version comparison: '<' not supported between instances of 'str' and 'int'\n\nThe error appears to be in '/project-path/plone/ansible-playbook/playbook.yml': line 11, column 7, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n\n    - name: Fail if Ansible is old\n      ^ here\n"}

Its complement was merged in plone/ansible.plone_server#134

TASK [Fail if Ansible is old] *****************************************************************************************************************************************************************************************************************************************
fatal: [example.com]: FAILED! => {"msg": "The conditional check 'ansible_version is version('2.5.0', 'lt')' failed. The error was: Version comparison: '<' not supported between instances of 'str' and 'int'\n\nThe error appears to be in '/project-path/plone/ansible-playbook/playbook.yml': line 11, column 7, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n\n    - name: Fail if Ansible is old\n      ^ here\n"}
@stevepiercy stevepiercy requested a review from smcmahon November 16, 2019 14:01
@jensens jensens requested a review from fulv November 18, 2019 21:26
@jensens jensens merged commit 2ecf0e5 into master Nov 18, 2019
@jensens jensens deleted the fix-version-compare branch November 18, 2019 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants