Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PLIP jobs: test against Py3 and Py2 #549

Closed
thet opened this issue Nov 3, 2018 · 8 comments
Closed

PLIP jobs: test against Py3 and Py2 #549

thet opened this issue Nov 3, 2018 · 8 comments
Assignees
@gforcada
Labels
04 type: enhancement 05 type: question

Comments

@thet
Copy link
Member

thet commented Nov 3, 2018

Currently we only test against Python 2 on PLIP jobs. We probably need a way to test against Python 3 and Python 2.
The easiest way to do this might be to provide 2 buildout configurations per PLIP.
@gforcada
Copy link
Member

gforcada commented Nov 3, 2018

Yeah, as I was fixing the jobs earlier before I did notice that...

Your idea sounds like a good solution. Let me put my kids to sleep and I will try to work on that.

@thet
Copy link
Member Author

thet commented Nov 3, 2018

:D
but it's no hurry!

@thet thet mentioned this issue Nov 4, 2018
Merged
@gforcada
Copy link
Member

gforcada commented Nov 4, 2018

@thet done! Now we have PLIP jobs targeting 2.7/3.6/3.7 things might be a bit off still, let me know:

plone/jenkins.plone.org@bac9d0e

@gforcada gforcada closed this as completed Nov 4, 2018
@thet
Copy link
Member Author

thet commented Nov 4, 2018

@gforcada awesome!
I recognized a problem when running:
https://jenkins.plone.org/view/PLIPs/job/plip-plone-staticresources-2.7/1/console

the plip configuration is referenced incorrectly - absolute to the filesystem's root:

buildout buildout:git-clone-depth=1 -c /plip-1653-staticresources.cfg

@thet thet reopened this Nov 4, 2018
@thet
Copy link
Member Author

thet commented Nov 5, 2018

@gforcada reminder for the broken PLIP initialization

This was referenced Nov 5, 2018
Closed
Closed
@gforcada
Copy link
Member

gforcada commented Nov 5, 2018

@thet I will have a look right now

@gforcada
Copy link
Member

gforcada commented Nov 5, 2018

Fixed (at least that bug, there might be others 😅 ): https://jenkins.plone.org/view/PLIPs/job/plip-plone-staticresources-2.7/3/console

@gforcada gforcada closed this as completed Nov 5, 2018
@thet
Copy link
Member Author

thet commented Nov 5, 2018

@gforcada tnx!

mister-roboto pushed a commit that referenced this issue Dec 21, 2024
@pbauer
[fc] Repository: plone.api
95632ad 
Branch: refs/heads/main
Date: 2024-12-20T06:52:47+01:00
Author: Philip Bauer (pbauer) <[email protected]>
Commit: plone/plone.api@0da4d70

Fix api.content.get when a item in the path is not accessible to the user (#549)

Files changed:
A news/549.bugfix
M src/plone/api/content.py
Repository: plone.api

Branch: refs/heads/main
Date: 2024-12-20T08:19:24+01:00
Author: Philip Bauer (pbauer) <[email protected]>
Commit: plone/plone.api@c6cfdb4

add test

Files changed:
M src/plone/api/tests/test_content.py
Repository: plone.api

Branch: refs/heads/main
Date: 2024-12-21T21:52:17+01:00
Author: Philip Bauer (pbauer) <[email protected]>
Commit: plone/plone.api@ef01287

Merge pull request #550 from plone/fix_getting_content_in_inaccessible_containers

Fix api.content.get when a item in the path is not acccessible

Files changed:
A news/549.bugfix
M src/plone/api/content.py
M src/plone/api/tests/test_content.py
mister-roboto pushed a commit that referenced this issue Dec 21, 2024
@pbauer
[fc] Repository: plone.api
ea8dc4c 
Branch: refs/heads/main
Date: 2024-12-20T06:52:47+01:00
Author: Philip Bauer (pbauer) <[email protected]>
Commit: plone/plone.api@0da4d70

Fix api.content.get when a item in the path is not accessible to the user (#549)

Files changed:
A news/549.bugfix
M src/plone/api/content.py
Repository: plone.api

Branch: refs/heads/main
Date: 2024-12-20T08:19:24+01:00
Author: Philip Bauer (pbauer) <[email protected]>
Commit: plone/plone.api@c6cfdb4

add test

Files changed:
M src/plone/api/tests/test_content.py
Repository: plone.api

Branch: refs/heads/main
Date: 2024-12-21T21:52:17+01:00
Author: Philip Bauer (pbauer) <[email protected]>
Commit: plone/plone.api@ef01287

Merge pull request #550 from plone/fix_getting_content_in_inaccessible_containers

Fix api.content.get when a item in the path is not acccessible

Files changed:
A news/549.bugfix
M src/plone/api/content.py
M src/plone/api/tests/test_content.py
mister-roboto pushed a commit that referenced this issue Dec 21, 2024
@pbauer
[fc] Repository: plone.api
4b04f8f 
Branch: refs/heads/1.x
Date: 2024-12-20T09:15:14+01:00
Author: Philip Bauer (pbauer) <[email protected]>
Commit: plone/plone.api@c8abe54

backport fix for #549

Files changed:
M src/plone/api/content.py
M src/plone/api/tests/test_content.py
Repository: plone.api

Branch: refs/heads/1.x
Date: 2024-12-20T09:16:49+01:00
Author: Philip Bauer (pbauer) <[email protected]>
Commit: plone/plone.api@8ca6c9e

add news

Files changed:
A news/551.bugfix
Repository: plone.api

Branch: refs/heads/1.x
Date: 2024-12-21T21:52:23+01:00
Author: Philip Bauer (pbauer) <[email protected]>
Commit: plone/plone.api@212bb72

Merge pull request #551 from plone/backport_549

 backport fix for #549

Files changed:
A news/551.bugfix
M src/plone/api/content.py
M src/plone/api/tests/test_content.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gforcada gforcada

Labels
04 type: enhancement 05 type: question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thet @gforcada