Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add terms to Glossary for block extension examples #1829

Merged
merged 3 commits into from
Jan 4, 2025

Conversation

stevepiercy
Copy link
Contributor

@stevepiercy stevepiercy commented Jan 3, 2025

This needs to be merged before plone/volto#6560 so that that PR can pull in the Glossary terms.


📚 Documentation preview 📚: https://plone6--1829.org.readthedocs.build/

ichim-david
ichim-david previously approved these changes Jan 3, 2025
Copy link
Member

@ichim-david ichim-david left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stevepiercy I am ok with these additions.
I see that we have this info here:
https://github.com/plone/volto/blob/374dfbcfe6a798fa66f8257e0f560fa1963d2646/docs/source/blocks/extensions.md?plain=1#L12

and
https://github.com/plone/volto/blob/374dfbcfe6a798fa66f8257e0f560fa1963d2646/docs/source/blocks/extensions.md?plain=1#L102

Ppl might not understand what InlineForm is and what it does but it can be a starting point for them to search for what is that component

docs/glossary.md Show resolved Hide resolved
@stevepiercy
Copy link
Contributor Author

@ichim-david yup, that's the source of the text I cobbled together.

@erral I simplified it in 05a3bd5.

@erral erral self-requested a review January 4, 2025 07:53
@stevepiercy stevepiercy merged commit 2cdffc6 into 6.0 Jan 4, 2025
3 checks passed
@stevepiercy stevepiercy deleted the block-examples-glossary-terms branch January 4, 2025 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants