Merge pull request #151 from plone/2.2.x-backport-addcreators-fix

Backport addCreator fix from master - refs #150
plone · May 26, 2021 · 9e7991d · 9e7991d
2 parents 0abce2a + 67f1e30
commit 9e7991d
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/news/150.bugfix b/news/150.bugfix
@@ -0,0 +1 @@
+addCreator should not add if a creator is already set for content. This prevents every editor on content from adding to the list of creators for an object. [avoinea, vangheem]
diff --git a/plone/dexterity/content.py b/plone/dexterity/content.py
@@ -361,6 +361,10 @@ def notifyModified(self):
     @security.protected(permissions.ModifyPortalContent)
     def addCreator(self, creator=None):
         # Add creator to Dublin Core creators.
+        if len(self.creators) > 0:
+            # do not add creator if one is already set
+            return
+
         if creator is None:
             user = getSecurityManager().getUser()
             creator = user and user.getId()
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		addCreator should not add if a creator is already set for content. This prevents every editor on content from adding to the list of creators for an object. [avoinea, vangheem]