Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop travis #8

Merged
merged 1 commit into from
Feb 15, 2018
Merged

Drop travis #8

merged 1 commit into from
Feb 15, 2018

Conversation

gforcada
Copy link
Member

No description provided.

@gforcada
Copy link
Member Author

@tomgross @mauritsvanrees I wanted to make a simple fix (#7) but the tox setup is so loose (there's no version pinning for anything) that is impossible to get it working without much effort.

Anyway plone.memoize is being tested daily on jenkins.plone.org, so regressions will not go unnoticed.

Copy link
Member

@mauritsvanrees mauritsvanrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to have Travis support, because there are not many dependencies. In .tox/py27/ locally:

$ bin/pip freeze
persistent==4.2.4.2
plone.memoize==1.2.2.dev0
python-gettext==3.0
pytz==2018.3
six==1.11.0
zope.annotation==4.6.0
zope.browser==2.2.0
zope.component==4.4.1
zope.configuration==4.1.0
zope.contenttype==4.3.0
zope.deprecation==4.3.0
zope.event==4.3.0
zope.exceptions==4.2.0
zope.i18n==4.3.1
zope.i18nmessageid==4.1.0
zope.interface==4.4.3
zope.location==4.1.0
zope.proxy==4.3.0
zope.publisher==4.3.2
zope.ramcache==2.2.0
zope.schema==4.5.0
zope.security==4.2.2
zope.testrunner==4.8.1

But yes, with those versions it fails.

It might be doable to figure out the correct versions. But since Jenkins indeed tests it, it should be okay do drop. I doubt plone.memoize is used outside of Plone.

@gforcada
Copy link
Member Author

@mauritsvanrees I take that as an ok to merge it :-)

@gforcada gforcada merged commit 25e4e78 into master Feb 15, 2018
@gforcada gforcada deleted the drop-travis branch February 15, 2018 10:15
@icemac icemac mentioned this pull request Aug 17, 2018
@icemac
Copy link

icemac commented Aug 17, 2018

@gforcada I think this is not the right way forward, so I created #9.
@mauritsvanrees This package is usable outside Plone and there are plans to let Products.ZCatalog depend on it, see zopefoundation/Products.ZCatalog#17.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants