- Sponsor
-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add portal_type title #1355
Add portal_type title #1355
Conversation
@razvanMiu thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment:
To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
Fixes partially #1322 |
63bb52d
to
b0cbce6
Compare
✅ Deploy Preview for plone-restapi canceled.
|
@jenkins-plone-org please run jobs |
@jenkins-plone-org please run jobs |
Assuming this is for Volto: A mapping from fti id to fti title can be received from state.types. No need to extend the serializers. |
@ksuess Can you detail a little. Is it available for anonymous users? |
So issue description has to be read as "There is no way to get the human readable title of the content-type as long the user is |
@jenkins-plone-org please run jobs |
Co-authored-by: David Glick <[email protected]>
One thing I don't get is where to put the documentation about this extra field? Isn't it self-explanatory with being just added in |
@stevepiercy may I head this one over to you? |
@jensens, I agree with @nileshgulia1. What do you think is needed in the way of documentation? I found no place where the REST API authors have documented the keys in a response. Do they want to start? |
@jenkins-plone-org please run jobs |
@jenkins-plone-org please run jobs |
Co-authored-by: David Glick <[email protected]>
@jenkins-plone-org please run jobs |
@jensens okay now from your point of view? |
@jenkins-plone-org please run jobs |
@jenkins-plone-org please run jobs |
This adds a new field
type
to content response which contains the title ofportal_type
.Example of why this is needed:
Let's say I have a content-type named
Topic page
with the idtopic_page
. Fetching a page of this content-type will respond with:There is no way to get the human readable title of the content-type so this pr will add a new field and the response will look like: