Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a specific robots.txt for Volto sites #183

Merged
merged 8 commits into from
Jan 23, 2025
Merged

Conversation

ericof
Copy link
Member

@ericof ericof commented Jan 21, 2025

Fixes #178

@ericof ericof requested review from davisagli and sneridagh January 21, 2025 20:59
@mister-roboto
Copy link

@ericof thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

Copy link
Member

@davisagli davisagli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ericof Mostly LGTM, but here are a few details to check, please.

news/178.feature Outdated Show resolved Hide resolved
news/178.feature Outdated Show resolved Hide resolved
src/plone/volto/upgrades.zcml Outdated Show resolved Hide resolved
@davisagli
Copy link
Member

@ericof Also see the failing test.

@ericof
Copy link
Member Author

ericof commented Jan 22, 2025

@jenkins-plone-org please run jobs

@ericof ericof requested a review from davisagli January 22, 2025 19:13
@ericof
Copy link
Member Author

ericof commented Jan 22, 2025

@jenkins-plone-org please run jobs

Copy link
Member

@davisagli davisagli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ericof Thanks!

@davisagli davisagli merged commit 74788ed into main Jan 23, 2025
11 checks passed
@davisagli davisagli deleted the issue-178-robots_txt branch January 23, 2025 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SEO issue: robots.txt blocks API calls made by Google
4 participants