Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hreflangs for Volto 16 #6615

Merged
merged 2 commits into from
Jan 23, 2025
Merged

hreflangs for Volto 16 #6615

merged 2 commits into from
Jan 23, 2025

Conversation

erral
Copy link
Member

@erral erral commented Jan 23, 2025


The same as #6603 for Volto 16.x

@erral
Copy link
Member Author

erral commented Jan 23, 2025

I think we can disregard the documentation tests here, right @stevepiercy ?

Copy link
Member

@iFlameing iFlameing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as previous everything is good :)

@stevepiercy
Copy link
Collaborator

@erral yes, we can ignore the RTD failures. We don't maintain 16.0 docs, and it we only recently supported RTD on main.

@davisagli
Copy link
Member

@stevepiercy Is there any way to disable the RTD builds for PRs targeting the 16.x.x and 17.x.x branches?

@davisagli davisagli merged commit 5d43823 into 16.x.x Jan 23, 2025
26 of 28 checks passed
@davisagli davisagli deleted the erral-hreflangs-16.x branch January 23, 2025 22:47
@stevepiercy
Copy link
Collaborator

@davisagli not that I could find. We could try removing the .readthedocs.yml file, since RTD complains that it lacks the sphinx.config key, or we could try adding that key and see if it stops complaining about that requirement and exits as it should. Let's try the latter. I can try later tonight, or you're welcome to take a stab at it.

@davisagli
Copy link
Member

@stevepiercy Ok. I don't think it's worth a large effort.

@stevepiercy
Copy link
Collaborator

To amend my last comment, deleting the .readthedocs.yaml file will still cause a failure.

https://readthedocs.org/projects/plone-registry/builds/26947396/

I think I can put a logical if in the workflow file.

https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/using-conditions-to-control-job-execution

If that doesn't have the desired effect, I'll try adding this snippet:

sphinx:
  # Path to your Sphinx configuration file.
  configuration: docs/src/conf.py

It won't handle the @plone/registry failure though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants