-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update meta tag information #99
Conversation
Hey @bradley-erickson Thanks for the PR! The I think it would be great if we could handle this without requiring people to enter more data in dash.register_page() For the url, I think this will work - it should capture the full
For the image, if it requires a full url, we can get the base path with
If you would like to make the update, I could deploy a tarball based on this PR, and see if it works. |
Knowing that sharing works for the |
OK, I'll try it with just changing the twitter card and seeing if it works for the image. update: |
Just need to add the new
|
Hey @bradley-erickson This looks fantastic and the @T4rk1n This is ready for a final review:
The changes are deployed in the dash-labs online docs, and we have verified that the Twitter card is fixed. The formatting, image and URL are all now correct. After it's merged I can do another release ad make an announcement on the forum. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💃 Looks good, verified the bird image appears in the twitter card validator
This is not fully tested, I do not have access to a domain I can test on to ensure that this works. This will need to be deployed to a domain in order to test properly. We can use https://metatags.io/ to ensure things are showing up properly after deploying.
I'm am not 100% sure how we should handle the image url and url information.
The changes can be described as the following:
twitter:card
will be set to "summary_large_image", this could perhaps be the default and we allow the user to choose the proper card type; however, I think this is the most often used Twitter card for sharing websites.image_url
is a new parameter to pass into each page. I figure that some people might enjoy accessing the image locally (through the assets folder using image), but we need to point to a proper image location for sharing.url
is used to specify the full path of the deployed instance instead of the relative path.