Headless? #65
Comments
|
@n-riesco @JamesCropcho @etpinard Any thoughts here? Do we need #63 to prevent the popup? |
|
@jackparmer I don't believe I'll win any popularity contests with my thoughts here, but I'll share them as you have requested. I do not believe that a window popping up for half a second (or even many such windows) in an application targeting computer-savvy types (e.g. Plotly users) is substantially "disruptive" to warrant significant effort from Plotly to remedy it. |
|
We've heard that pop-ups with [current offline PNG generation](https://plot.ly/python/static-image-export/) cause issues when generating many images in series on a server without a display. For example, we have customers who would like to generate thousands of plot images as part of a nightly batch process. So, yep, this should be resolved.
|
|
@jackparmer Ah, okay. That is a different use-case than @jmmease described. I don't have any experience with this particular issue.
@n-riesco's suggestion above sounds like as a good an initial experiment/step, as any. More broadly, an experimental approach is probably needed, i.e. trying various ideas which seem promising and seeing what works. |
@jackparmer As the author of #63, I am pretty sure that #63 would neither fix this, nor exacerbate it. |
|
This issue is essentially a duplicate of #22 This repo won't attempt to do anything fancy (e.g. |
|
I just tried out @n-riesco suggestion and added Would this be a reasonable command line option eventually? |
|
What does |
Definitely. The longterm vision was to package this with plotly.py so we stop getting complaints like this: plotly/plotly.py#880 (comment) |
|
Interesting, it seems that the But when I do pdf export There are actually two popup windows, and only the first one is hidden by the |
|
what if you add |
|
Yep, I saw that page, but
isn't very clear. I guess I could try it out myself. Sorry for being lazy. |
|
@etpinard Awesome, adding |
|
Well, initial experimentation makes it sound easy enough… If someone else is assigned this or has stepped up, by all means I am fine with someone else spearheading this. Or if not, upon request I can draft a pull request with these |
|
@JamesCropcho - Please go ahead and make a PR for this. Afterwards we can merge #63 and put out the first release! 🍾 |
|
@jmmease Are you able to see #66? If so, is it identical to the changes you made, which worked as desired? |
* #65 (comment) * "Probably best to set show: opts.debug for debugging purposes." * "shall we add show: false to the server too?" * "there's a few more createBrowserWindow calls" "Moreover, here too we should set show: opts.debug." * `remote.createBrowserWindow`'s `show` parameter appears to treat `undefined` as true. This commit performs like casting to a Boolean. * "On Windows and Linux, setting this to true should keep the electron window from displaying in the taskbar, which I believe to be desirable for making image export a seamless experience for Windows and Linux Python/R users. I think this change would just involve adding the skipTaskbar option everywhere the show option is added." * "To hide the electron icon from the dock on OS X it is recommended (electron-userland/electron-builder#1456) to add "extendInfo": {"LSUIElement": 1} to the top-level mac configuration settings" * Manual reverting of changes in package.json from previous commits on `forbid-popup-windows`
|
Closed via #72 |
I built the project on OS X and ran the following png export command
The
out.pngimage is generated successfully, but I noticed that the electron window pops up in front of my other windows.Is there any way to prevent the popup? I'm concerned this would be a bit disruptive for eventual python/R users.
cross reference: #21, plotly/plotly.py#880
cc: @cpsievert @etpinard @jackparmer
The text was updated successfully, but these errors were encountered: