Account for new changes in ggplot2's internal API, fixes #1561 #1572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schloerke
reviewed
Jul 12, 2019
schloerke
reviewed
Jul 12, 2019
schloerke
requested changes
Jul 12, 2019
Can you elaborate? It behaves very similarly to What would you propose as an alternative? This is already a common enough pattern (if a certain field is a function, call it and return that value; otherwise, fallback on something else) that I'd like a helper for it |
* Break values of positional scales have moved from to * Text labels of positional scales have moved from to * sf graticule degree labels are now quoted?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1561 and tidyverse/ggplot2#3436