Fix race conditions in _permissions() (#1498)

plotly · Apr 8, 2019 · 133df4d · 133df4d
1 parent b13b2ba
commit 133df4d
Showing 1 changed file with 11 additions and 3 deletions.
diff --git a/plotly/files.py b/plotly/files.py
@@ -27,12 +27,20 @@
 def _permissions():
     try:
         if not os.path.exists(PLOTLY_DIR):
-            os.mkdir(PLOTLY_DIR)
+            try:
+                os.mkdir(PLOTLY_DIR)
+            except Exception:
+                # in case of race
+                if not os.path.isdir(PLOTLY_DIR):
+                    raise
         with open(TEST_FILE, 'w') as f:
             f.write('testing\n')
-        os.remove(TEST_FILE)
+        try:
+            os.remove(TEST_FILE)
+        except Exception:
+            pass
         return True
-    except:
+    except Exception: # Do not trap KeyboardInterrupt.
         return False