-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mpl-like template #1864
Add mpl-like template #1864
Conversation
e5a279e
to
53595ec
Compare
How about naming the template |
Let's go with The reason you don't get axis lines in the inner plots in a SPLOM is that there aren't any axes there. Unlike the output of |
Done! I wont add any new things now, just fix what you think need fixing. This is what the scatter matrix looks like with the added transparency. Ideally I would remove the upper half and show histograms on the diagonal, but I suspect that would be too much alteration in an official template so I will make those changes locally instead. |
I don't think I'm a fan of the opacity changes to scatter... none of our other templates do this and I'd like for there to be at least some measure of consistency about this :) |
I also think the lines around the bars are too strong... can we use the same thickness as in the |
I think it is a useful way to indicate saturated plots, but I also get your points about consistency, removed.
Hmm, doesn't the plotly templates use 0 linewidth? I changed it to 0.6 in my latest commit, looks like this: |
This is looking pretty solid, thanks very much! Once #1875 lands we can rebase it on top of that one and then I can kick the tires a bit more and merge it in :) Thanks for all the patience and enthusiasm on these PRs and issues over the past few weeks! |
OK, if you can rebase onto |
2a00da2
to
18abf79
Compare
@nicolaskruchten Rebased |
Looking really good! Some observations from rendering the Plotly Express gallery notebook with
These don't necessarily have to change but they're worth a think Other than those two items, this is ready for merging! |
Thanks!
Yes, this was a change I suggested in #1863 but it didn't make it into #1875. I created a new PR #1882.
Done |
OK, I'm very happy to merge this now and we can figure out #1882 separately (hopefully still for 4.3!) A big thank you for working through this whole thing with us :) |
Thanks for helping me contribute! |
@nicolaskruchten The PR is finally here! There are still a few things to test, but please have a look nd let me know if this makes sense so far. Notably, I still have to tend to these items
test table colorsgo.Table appearance ignores the deafult PX template #1869no axes lines in scatter matrixsee comment posted belowno ticks on colorbarsMake colorbars respect template configurations #1867I suggest naming this template mpl as a reference to the default style in matplotlib. The most notable difference would be that the top and rightmost axis lines are omitted here whereas matplotlib plots full boxes around the plots by default. The ticks, bg color, and color rotations are all the same as the default matplotlib style (altuogh I kept gray14 as the black color for now). I thought it made sense with this consistency so I included Viridis as the default color map instead of Inferno or Blues which I would be more likely to choose myself. For complete adherence, I could add the full box and then make another template called "despine" or similar to remove the topmost and rightmost axis lines.
I would also be happy to call this template xticks or axes lines and be more liberal in some of the choices, let me know what you think makes the most sense.
Some screens:
![image](https://user-images.githubusercontent.com/4560057/68098276-115b1780-febc-11e9-999b-6d8eff703819.png)
close #1834