Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Icicle Trace to Plotly.py #3139

Closed
wants to merge 6 commits into from
Closed

Add Icicle Trace to Plotly.py #3139

wants to merge 6 commits into from

Conversation

Kully
Copy link
Contributor

@Kully Kully commented Apr 7, 2021

Code PR

  • I have read through the contributing notes and understand the structure of the package. In particular, if my PR modifies code of plotly.graph_objects, my modifications concern the codegen files and not generated files.
  • I have added tests (if submitting a new feature or correcting a bug) or
    modified existing tests.
  • For a new feature, I have added documentation examples in an existing or
    new tutorial notebook (please see the doc checklist as well).
  • I have added a CHANGELOG entry if fixing/changing/adding anything substantial.
  • For a new feature or a change in behaviour, I have updated the relevant docstrings in the code to describe the feature or behaviour (please see the doc checklist as well).

Other changes in this PR

  • Correct setup.py by changing publish to publish-dist. See this line
  • Correct the path to plotly express in contributing.md

@nicolaskruchten
Copy link
Contributor

Thanks! This is the right first commit to get this into the library, but I likely won't want to merge this PR alone: I would recommend that you build the PX support and docs into this PR, and I'll rebase and merge on top of master once Plotly.js 2.0 is released and Plotly.py is upgraded to use it.

@Kully
Copy link
Contributor Author

Kully commented Apr 7, 2021

I would recommend that you build the PX support and docs into this PR

Sounds good. I am currently working on some basic docs right now.

@nicolaskruchten
Copy link
Contributor

Merged via cherry-pick.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants