feat(arcs): introduce @nivo/arcs package #1331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 03f8702:
|
|
sounds really cool 👍 |
|
@wyze if you could have a look at this PR, that would be great, I'm sorry, it's huge 🙇🏻 |
|
Of course @plouc, but only if you look at my axes PR next. :) |
|
Right, sorry also for that, in fact I already started, I'm gonna try to finish reviewing it in the next upcoming days. |
wyze
reviewed
Dec 17, 2020
wyze
reviewed
Dec 17, 2020
wyze
suggested changes
Dec 17, 2020
packages/arcs/src/arc_link_labels/useArcLinkLabelsTransition.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Neil Kistner <[email protected]>
@wyze, thank you for the review, and the fixes! regarding directory name, I tend to use underscores in most of my projects, so I would prefer to use them. |
wyze
approved these changes
Dec 17, 2020
This was referenced Dec 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this PR was initially to add transitions to
@nivo/pie, but when starting to implement it, I realized that this should also be useful for a few existing packages:@nivo/pie,@nivo/chordand@nivo/sunburst, which led me to think of introducing a@nivo/arcpackage.This also allows us to move some logic specific to arcs in this new package like cursor detection for canvas charts, hooks for configuring and memoizing a d3 arc generator... while making the core package a bit lighter.
I haven't integrated it yet in the sunburst package as it might require a bit of work, and just replaced the cursor detection in the chord package, but ultimately, we should use more from this new package.
It could also help building new chart types such as a Rose chart.