-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JS tracking and AMP compatibility #110
Comments
I haven't looked at this any closer so far than reading the documentation in https://github.com/ampproject/docs/blob/master/content/docs/analytics/analytics-vendors.md, so I can't really be of any help here unfortunately. This generally is the right approach, of course I'm not aware about the specific details that Statify would require. However the article seems to give a good headstart. Regarding the implementation, it would probably be best if Statify supported this out-of-the-box, without requiring manual addition of the complicated information via the AMP plugin. The plugin might as well check |
@felixarntz Thanks for your feedback! :) |
* Update class-statify-frontend.php * Add filter for AMP analytics * Update class-statify.php * minor code style corrections (no semantics changed) * do not append AMP analytics script if no JS tracking is used * do not specity "type" attribute for AMP analytics script There is no valid analytics vendor "statify" and we trigger a local endpoint. To prevent AMP analtics from calling a vendor-endpoint with 404 result in this case, the type attribute is left empty. * docs++ * adjust AMP analytics config to issue a POST request for WP-AJAX Co-authored-by: Stefan Kalscheuer <[email protected]> Co-authored-by: Torsten Landsiedel <[email protected]> Co-authored-by: Patrick Robrecht <[email protected]>
I stumbled upon this blog post about making Statify AMP compatible:
https://die-computermaler.de/statify-und-amp-accelerated-mobile-pages/
So we could try to do this programmatically (automatic or per option) or we can add this to our documentation.
The text was updated successfully, but these errors were encountered: