Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced Support LInk with translatable version #126

Conversation

arkonisus
Copy link
Contributor

fixes #122

@krafit
Copy link
Member

krafit commented Mar 22, 2019

What do you think about adding a translation comment? This way we can explain to translators what to do with this link.

Copy link
Member

@Zodiac1978 Zodiac1978 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

esc_urlscheint die passendere Funktion zu sein. Und im ersten Fall ist ein echo gar nicht nötig, da es innerhalb von PHP übergeben wird.
Siehe: https://codex.wordpress.org/Function_Reference/esc_url

@Zodiac1978 Zodiac1978 merged commit b017462 into pluginkollektiv:master Mar 22, 2019
@stklcode stklcode added this to the 1.7.0 milestone Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support link is not translatable
4 participants