Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to show total visits #134

Merged
merged 3 commits into from
Nov 11, 2019
Merged

Add option to show total visits #134

merged 3 commits into from
Nov 11, 2019

Conversation

yurihs
Copy link
Contributor

@yurihs yurihs commented Oct 1, 2019

Hi! This should resolve #128.

Please let me know if there are any problems.

@stklcode
Copy link
Contributor

stklcode commented Oct 2, 2019

Thanks very much @yurihs for this work.
I've only had a look into the code so far. Implementation looks good to me.

One additional suggestion though:
"all time" is quite a flexible time range. Might be the last 5 days or the last 5 years depending on configuration and actual traffic.
What about adding the information "since [date]" , either instead or in addition of "all time"?

@yurihs
Copy link
Contributor Author

yurihs commented Oct 2, 2019

That makes sense! Please have another look @stklcode.

@stklcode
Copy link
Contributor

stklcode commented Oct 3, 2019

Great! I've added a minor CSS correction for alignment with the pre-existing tables.

Works fine on top of the current master. With #72 merged, $stats['visits'][0]['date'] is no longer correct, because this would display the overall totals from the database along with the oldest date from the display range.

Feel free to work around this, but I have to rework my PR anyway, so I can take care of that there.

@stklcode stklcode added this to the 1.7.0 milestone Oct 3, 2019
@Zodiac1978 Zodiac1978 merged commit 085d249 into pluginkollektiv:master Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show number of total views tracked by Statify
3 participants