fix 1 day offset for top list range #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Top lists are either generated for "today" or for the whole display range. The underlying query however returns one day more than expected, if storage range is greater display range.
stklcode
force-pushed
the
fix/top-list-offset
branch
from
fa13bd1 to
c6896d6
Compare
patrickrobrecht
approved these changes
Jun 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Top lists are either generated for "today" or for the whole display range.
The underlying query however returns one day more than expected, if storage range is greater display range.
obviously fetches data of "x days ago" inclusive which makes x+1 days with today, so one more than expected.
The visit query is not affected because it uses
LIMIT %din the aggregation query and the Cron cleanup usescreated <= DATE_SUB(...)so it's done right there.