Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support "disallowed_keys" instead of "blacklist" for WP 5.5 compat #174

Merged
merged 2 commits into from
Aug 1, 2020

Conversation

stklcode
Copy link
Contributor

In WordPress 5.5 the "comment blacklist" has been renamed to "disallowed comment keys" along with the corresponding option key1.

We now support the new option, if available.
Also the frontend wording is adapted to match the new labels.
Private methods and comments changed where reasonable. Public methods and internal option names left untouched for backwards compatibility.

[1] https://make.wordpress.org/core/2020/07/23/codebase-language-improvements-in-5-5/

The "comment blacklist" has been renamed to "disallowed comment keys"
along with the corresponding option key. We now support the new option,
if available. Also the frontend wording is adapted to match the new
labels.
@patrickrobrecht patrickrobrecht added this to the 1.8.0 milestone Jul 25, 2020
Copy link
Member

@patrickrobrecht patrickrobrecht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, then we can release Statify 1.8.0 with support for WordPress 5.5 already.

@patrickrobrecht patrickrobrecht merged commit ff40f5b into develop Aug 1, 2020
@patrickrobrecht patrickrobrecht deleted the fix/blacklist-option-wp55 branch August 1, 2020 15:17
@stklcode stklcode restored the fix/blacklist-option-wp55 branch August 1, 2020 20:54
@stklcode stklcode deleted the fix/blacklist-option-wp55 branch August 1, 2020 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants