Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always register the action for the cleanup #187

Merged
merged 1 commit into from
Oct 20, 2020
Merged

Always register the action for the cleanup #187

merged 1 commit into from
Oct 20, 2020

Conversation

patrickrobrecht
Copy link
Member

Resolves #184

stklcode
stklcode approved these changes Oct 20, 2020
View reviewed changes
Copy link
Contributor

@stklcode stklcode left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be enough to register it for cron and admin calls. But the overhead of registering an unused action is minimal, so I’m fine with the proposed solution.

@stklcode stklcode added this to the 1.8.1 milestone Oct 20, 2020
@stklcode stklcode merged commit e556f89 into develop Oct 20, 2020
@stklcode stklcode deleted the fix/184-cron branch October 20, 2020 06:15
@stklcode stklcode mentioned this pull request Oct 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stklcode stklcode stklcode approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.8.1
Development

Successfully merging this pull request may close these issues.

No action shown in WP Crontrol
2 participants
@patrickrobrecht @stklcode