Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove double closing tag on value attribute of radio buttons #206

Merged
merged 1 commit into from
May 26, 2021
Merged

remove double closing tag on value attribute of radio buttons #206

merged 1 commit into from
May 26, 2021

Conversation

stklcode
Copy link
Contributor

Radio buttons in the settings form, i.e. selector for JS tracking mode contains a superfluous > character in the value attribute because of doubled closing tag after the PHP sequence.

<input name="statify[snippet]" type="radio" value="0>">
                                                    ^
----------------------------------------------------|

@stklcode stklcode added the bug label May 25, 2021
@stklcode stklcode added this to the 1.8.2 milestone May 25, 2021
florianbrinkmann
florianbrinkmann approved these changes May 26, 2021
View reviewed changes
Copy link
Member

@florianbrinkmann florianbrinkmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stklcode stklcode merged commit 5c61678 into develop May 26, 2021
@stklcode stklcode deleted the fix/radioMarkup branch May 26, 2021 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florianbrinkmann florianbrinkmann florianbrinkmann approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
1.8.3
Development

Successfully merging this pull request may close these issues.
2 participants
@stklcode @florianbrinkmann