Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add uk locale #154

Merged
merged 2 commits into from
Dec 22, 2023
Merged

Add uk locale #154

merged 2 commits into from
Dec 22, 2023

Conversation

HighError
Copy link
Contributor

What does it do?

Added ukrainian localization

Why is it needed?

For ukrainian users

How to test it?

  • yarn build - successfully
  • Local strapi instance
    image

Related issue(s)/PR(s)

--

Copy link
Member

@boazpoolman boazpoolman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't the official shortcode for Ukraine ua?
I see that Strapi internally uses uk for their own translations as well. So this PR looks all good to me!

Thanks for your contribution :)

@HighError
Copy link
Contributor Author

I think the Strapi repository agreed to use uk. Although in most cases I notice exactly uk, not ua. This is really confusing with the fact that uk can be spelled as United Kingdom.

@boazpoolman boazpoolman merged commit 0f09273 into pluginpal:master Dec 22, 2023
4 checks passed
@HighError HighError deleted the add-uk-locale branch December 22, 2023 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants