Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements #353

Merged
merged 3 commits into from
Jul 18, 2023
Merged

Improvements #353

merged 3 commits into from
Jul 18, 2023

Conversation

bouwew
Copy link
Contributor

@bouwew bouwew commented Jul 15, 2023

Code improvements:

  • Remove double _smile_legacy functionality
  • combine _locations_specials() with _all_locations()

@codecov
Copy link

codecov bot commented Jul 16, 2023

Codecov Report

Merging #353 (6e9825c) into main (0804cf9) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #353   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines         2646      2640    -6     
=========================================
- Hits          2646      2640    -6     
Impacted Files Coverage Δ
plugwise/constants.py 100.00% <ø> (ø)
plugwise/__init__.py 100.00% <100.00%> (ø)
plugwise/helper.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bouwew bouwew marked this pull request as ready for review July 16, 2023 12:02
@bouwew bouwew requested a review from CoMPaTech as a code owner July 16, 2023 12:02
Copy link
Member

@CoMPaTech CoMPaTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bouwew bouwew merged commit fac1de5 into main Jul 18, 2023
@bouwew bouwew deleted the p1v2-fail branch July 18, 2023 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants