Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Off-option in the available-schedules list #450

Merged
merged 35 commits into from
Nov 17, 2023
Merged

Add Off-option in the available-schedules list #450

merged 35 commits into from
Nov 17, 2023

Conversation

bouwew
Copy link
Contributor

@bouwew bouwew commented Nov 16, 2023

Selecting the Thermostat schedule "Off" option in pw-beta will turn the off the schedule for a location.

This could be a solution for what's discussed in plugwise/plugwise-beta#523

@bouwew bouwew requested a review from CoMPaTech November 16, 2023 09:37
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (202263d) 100.00% compared to head (e21bf5e) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #450   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines         2765      2783   +18     
=========================================
+ Hits          2765      2783   +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bouwew
Copy link
Contributor Author

bouwew commented Nov 16, 2023

Not working yet, needs a little more work...

@bouwew bouwew marked this pull request as ready for review November 17, 2023 10:01
@bouwew bouwew requested a review from a team as a code owner November 17, 2023 10:01
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
10.5% 10.5% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@bouwew bouwew merged commit 71855e4 into main Nov 17, 2023
19 of 20 checks passed
@bouwew bouwew deleted the schedule_off branch November 17, 2023 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants