Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tightens the logic getting the current version to avoid multiple returns #16

Merged
merged 2 commits into from
Jun 20, 2023
Merged

Tightens the logic getting the current version to avoid multiple returns #16

merged 2 commits into from
Jun 20, 2023

Conversation

lorengordon
Copy link
Member

For example, taking the .bumpversion.cfg from slack-aws-notifier:

❯ grep "current_version" .bumpversion.cfg
current_version = 3.2.0
search = "version": "{current_version}"
search = "version": "{current_version}"

vs the new logic:

❯ grep -E "current_version\s*=" .bumpversion.cfg
current_version = 3.2.0

Will fix release failures such as this one: https://github.com/plus3it/terraform-aws-slack-notifier/actions/runs/5323905775/jobs/9642557972

@lorengordon lorengordon requested a review from a team June 20, 2023 14:57
@lorengordon lorengordon merged commit 2604a33 into plus3it:main Jun 20, 2023
@lorengordon lorengordon deleted the fix/release-check branch June 20, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnricords johnricords johnricords approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lorengordon @johnricords