Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds workflow for running salt test on windows #18

Merged
merged 6 commits into from
Jun 26, 2023

Conversation

lorengordon
Copy link
Member

No description provided.

@lorengordon lorengordon requested a review from a team June 26, 2023 15:06
@lorengordon lorengordon force-pushed the feat/add-salt-windows-test branch 2 times, most recently from 2b6f576 to 04122cd Compare June 26, 2023 15:19
dependabot bot and others added 3 commits June 26, 2023 08:31
Bumps plus3it/tardigrade-ci from 0.24.6 to 0.24.7.

---
updated-dependencies:
- dependency-name: plus3it/tardigrade-ci
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [reviewdog/action-actionlint](https://github.com/reviewdog/action-actionlint) from 1.37.0 to 1.37.1.
- [Release notes](https://github.com/reviewdog/action-actionlint/releases)
- [Commits](reviewdog/action-actionlint@42de1e3...7485c21)

---
updated-dependencies:
- dependency-name: reviewdog/action-actionlint
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@lorengordon lorengordon force-pushed the feat/add-salt-windows-test branch from 04122cd to 2b5087d Compare June 26, 2023 15:33
@lorengordon lorengordon force-pushed the feat/add-salt-windows-test branch from 2b5087d to bb6620e Compare June 26, 2023 17:11
@@ -46,7 +46,7 @@ jobs:
uses: actions/checkout@c85c95e3d7251135ab7dc9ce3241c5835cc595a9
with:
fetch-depth: 0
- run: git fetch --tags --force origin # WA: https://github.com/actions/checkout/issues/882
- run: git fetch --tags --force origin # WA: https://github.com/actions/checkout/issues/882
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: Is this extra whitespace intentional?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's coming from yamllint, in the 0.24.7 version of tardigrade-ci, and its default rules for comments, https://yamllint.readthedocs.io/en/stable/rules.html#module-yamllint.rules.comments. In particular, this one:

    min-spaces-from-content: 2

@lorengordon lorengordon enabled auto-merge June 26, 2023 19:04
@lorengordon lorengordon merged commit 84885d2 into plus3it:main Jun 26, 2023
@lorengordon lorengordon deleted the feat/add-salt-windows-test branch June 26, 2023 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants