Uses click for cli argument processing #284
Conversation
|
Opening for discussion. Still need to test on Windows. |
Codecov Report
@@ Coverage Diff @@
## develop #284 +/- ##
===========================================
+ Coverage 18.12% 18.23% +0.11%
===========================================
Files 13 13
Lines 822 817 -5
Branches 92 91 -1
===========================================
Hits 149 149
+ Misses 673 668 -5
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## develop #284 +/- ##
===========================================
+ Coverage 18.12% 18.21% +0.08%
===========================================
Files 13 13
Lines 822 818 -4
Branches 92 91 -1
===========================================
Hits 149 149
+ Misses 673 669 -4
Continue to review full report at Codecov.
|
|
I am reading through on click currently. I certainly have no objections to switching over to a tool that is more in line with what we need for Watchmaker especially since argparse tends to cause odd behavior on installations from pypi. |
Replaces argparse. The argparse library dependency was required to use argparse on py26, but the libary is not actively maintained. Argparse is actively maintained as a core python library, but only available in py27 and later. Installing argparse from pypi can result in some odd behavior on imports, as we may get the core library _or_ the pypi library (depending on platform, typically). Using click ensures consistent behavior across all platforms and python versions.
Replaces argparse. The argparse library dependency was required to
use argparse on py26, but the libary is not actively maintained.
Argparse is actively maintained as a core python library, but only
available in py27 and later. Installing argparse from pypi can
result in some odd behavior on imports, as we may get the core
library or the pypi library (depending on platform, typically).
Using click ensures consistent behavior across all platforms and
python versions.
I looked at
invokealso, but couldn't figure out how to replicate some of our option types, and felt the docs weren't quite as mature asclick. This implementation withclickresults in identical cli usage as the prior approach withargparse.