Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preferences restructured. New "Event filters" header introduced #171

Merged
merged 4 commits into from
Mar 22, 2015
Merged

Preferences restructured. New "Event filters" header introduced #171

merged 4 commits into from
Mar 22, 2015

Conversation

yvolk
Copy link
Collaborator

@yvolk yvolk commented Mar 21, 2015

New "Event filters" header introduced to allow further filtering enhancements.
Old "Events" header renamed to "Event details" - this is exactly what it is after removing "filters" from it!

Now it's much clearer to see, where we will put other proposed options like:
#151 Add ability to hide calendar events
#122 Show events that ended in past X hours (configurable)

and similar...

walles and others added 4 commits October 11, 2014 07:17
2. Background color of Past date headers is set according to "Past events background color" setting now.
yvolk added a commit that referenced this pull request Mar 22, 2015
1. Preferences restructured. New "Event filters" header introduced
2. Added preference "Show days without events".
3. Background color of Past date headers is set according to "Past events background color" setting.
@yvolk yvolk merged commit ad9410b into plusonelabs:master Mar 22, 2015
@mpost
Copy link
Collaborator

mpost commented Mar 22, 2015

When updating the strings please make sure to also update the strings.xml file on crowdin.

@yvolk
Copy link
Collaborator Author

yvolk commented Mar 22, 2015

Now the widget with
"Show days without events" turned on and
"Show past events with color" looks like this:
dayswithoutevents

@yvolk
Copy link
Collaborator Author

yvolk commented Mar 22, 2015

@mpost Ok, please grant me permission at Crowdin.com to update files. I joined the https://crowdin.com/project/plusonelabs-calendar-widget project.

@mpost
Copy link
Collaborator

mpost commented Mar 22, 2015

@yvolk You should now be a manager on the project. :)

Let me know if you need help finding your way around. Atm you just upload the the new strings.xml file in english and people will be able to contribute translations.

@yvolk
Copy link
Collaborator Author

yvolk commented Mar 23, 2015

@mpost Thank you, a while back I already noticed that you are using Crowdin.com for translation and arranged the same for AndStatus, so I have some experience :-)
BTW, you may be interested in using FB2 eBook format for a User Guide of Android application, see this discussion.

@mpost
Copy link
Collaborator

mpost commented Mar 23, 2015

@yvolk Good to see that you have experience.

Also pretty cool how so many translaters jumped in immediatly to translate the missing strings after your mail. :)

What i don't like about crowdin is how they map to the android language codes. You always have to copy the content to the right strings.xml files by hand. None the less the service itself is pretty nice.

@yvolk
Copy link
Collaborator Author

yvolk commented Mar 23, 2015

@mpost Fo far I used only two-letters language codes for translations, so I didn't notice this problem in Crowdin.com. Maybe we can really rename in repository e.g. "values-bg" to "values-bg-rBG" and thus simplify our lifes?!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants