Multiformat support #5

pm-manasi-moghe · 2019-01-16T05:45:51Z

Type of change

Bugfix
Feature
New bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other

Description of change

test parameters for validating bids

{
  bidder: '<bidder name>',
  params: {
    // ...
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

contact email of the adapter’s maintainer
official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

A link to a PR on the docs repo at https://github.com/prebid/prebid.github.io/

Other information

Latest Pull

Latest Code

Latest

…ativesupport

changes to support native in pubmaticbid adapter

documentation for native

Review comments from Prebid

…into multiformat_support Conflicts: modules/pubmaticBidAdapter.js

pm-harshad-mane · 2019-01-17T00:51:13Z

modules/pubmaticBidAdapter.js

+import { registerBidder } from 'src/adapters/bidderFactory';
+import { BANNER, VIDEO, NATIVE } from 'src/mediaTypes';
+import {config} from 'src/config';
+const constants = require('src/constants.json');


are we not using constants?

Its not getting used anywhere in the file. hence gulp lint was throwing an error for unused variable.

pm-harshad-mane · 2019-01-17T00:52:04Z

modules/pubmaticBidAdapter.js

@@ -207,7 +208,7 @@ function _parseAdSlot(bid) {
  bid.params.adUnitIndex = '0';
  bid.params.width = 0;
  bid.params.height = 0;
-  var sizesArrayExists = (bid.hasOwnProperty('sizes') && utils.isArray(bid.sizes) && bid.sizes.length >= 1);
+  // var sizesArrayExists = (bid.hasOwnProperty('sizes') && utils.isArray(bid.sizes) && bid.sizes.length >= 1);


can we delete the statement?

I have just commented out old code for now, till i am testing it. Will remove all commented code before QA drop.

pm-harshad-mane · 2019-01-17T00:54:15Z

modules/pubmaticBidAdapter.js

-  } else if (sizesArrayExists) {
+    // delete bid.sizes;
+  } else {
+    bid.params.width = parseInt(bid.mediaTypes.banner.sizes[0][0]);


what if mediaTypes.banner is not present? this line will throw an error.

In case of prebid, for a single banner format ad, if mediaTypes is not set by publisher, prebid adds that itself. So it should not happen that mediaTypes is not present. I can add a check, just in case, but what should be the behaviour in that scenario?

pm-harshad-mane · 2019-01-17T00:54:59Z

modules/pubmaticBidAdapter.js

    bid.params.width = parseInt(bid.sizes[0][0]);
    bid.params.height = parseInt(bid.sizes[0][1]);
-  }
+  } */


better if we delete the commented code, we can find it in older versions of code if required.

yes, will delete once i am done with development.

pm-harshad-mane · 2019-01-17T03:04:14Z

modules/pubmaticBidAdapter.js

+          sizes = bid.mediaTypes.banner.sizes;
+          if (sizes !== undefined && utils.isArray(sizes)) {
+            if (!bid.params.width && !bid.params.height) {
+              bannerObj.w = sizes[0][0];


let's add parseInt() on every size: width and height.
I think the current code accepts an array of strings as well in the same format

pm-harshad-mane · 2019-01-17T03:06:49Z

modules/pubmaticBidAdapter.js

+
+          break;
+        case VIDEO:
+          var videoData = bid.params.video;


can we move following video specific code in a separate function like _createNativeRequest?
smaller functions make code easy to understand and maintain.

pm-harshad-mane · 2019-01-17T03:09:19Z

modules/pubmaticBidAdapter.js

+
+            impObj.video = videoObj;
+          } else {
+            utils.logWarn(BIDDER_CODE + 'Error: Video config params missing for adunit: ' + bid.params.adUnit + ' with mediaType set as video. Ignoring the adunit.');


here we are ignoring video part of the adunit, not the whole adUnit, we need to correct the message here, also for other mediaTypes.

pm-harshad-mane · 2019-01-17T03:10:02Z

modules/pubmaticBidAdapter.js

+            }
+            // read playersize and assign to h and w.
+            if (utils.isArray(bid.mediaTypes.video.playerSize[0])) {
+              videoObj.w = bid.mediaTypes.video.playerSize[0][0];


pm-harshad-mane · 2019-01-17T03:15:31Z

modules/pubmaticBidAdapter.js

+// TODO: need a better way to identify mediaType from response.
+function _checkMediaType(adm, newBid) {
+  var admStr = '';
+  if (adm.indexOf('<VAST version=>') >= 0) {


need to consider case-insensitive regex, as there will be whitespaces
version=> will not satisfy for version=3.0>

pm-harshad-mane · 2019-01-17T03:16:17Z

modules/pubmaticBidAdapter.js

+  var admStr = '';
+  if (adm.indexOf('<VAST version=>') >= 0) {
+    newBid.mediaType = VIDEO;
+  } else if (adm.indexOf('span class="PubAPIAd"') >= 0) {


need to consider case-insensitive regex, as there will be whitespaces

merge master into branch

rebase

* RTBHouse Bid Adapter: add global vendor list id * structured user agent - browsers.brands * fix lint errors * Added sda into rtbhouse adapter * spreading ortb2: user & site props * examples reverted * init version * using mergedeep * removed wrong imp array augm.; slot imp augm. with addtl check * [SUA] merging ortb2.device into request * fledge auctionConfig adapted to our bid response structure * new bidder response structure for fledge * make sure bidderRequest has proper flag turned on * fledge endpoint hardcoded; code cleanups * remove obsolete function * obsolete function removed * [RTB House] Process FLEDGE request/response (#4) * [SDA & SUA] refactor using mergedeep * [FLEDGE] fledge auctionConfig adapted to our bid response structure * [FLEDGE] new bidder response structure for fledge * [FLEDGE] make sure bidderRequest has proper flag turned on * [FLEDGE] fledge endpoint hardcoded; code cleanups * [FLEDGE] remove obsolete functions * fixed lint errors * fledge test suites; adapter: delete imp.ext.ae when no fledge (#5) Co-authored-by: Leandro Otani <[email protected]> Co-authored-by: rtbh-lotani <[email protected]> Co-authored-by: Tomasz Swirski <[email protected]>

pm-shashank-jain and others added 30 commits November 27, 2018 12:45

Merge pull request #1 from prebid/master

7e5986c

Latest Pull

Merge pull request #2 from prebid/master

d1146d7

Latest Code

changes to support native in pubmaticbid adapter

609ec16

Removed port from endpoint

792b854

Removed protocol from endpoint

b6740d0

Formatting

0569f41

Fix request payload

fd6bf03

Updated test case

bd14420

Changed request and response as per ortb spec

65e2f1e

Change in request and response

13c87de

Removed comments and extra code

d9f3562

Code Review comments

adbc774

Code Review Comments and Test cases for request and response

21fe846

Removed data type as all data asset types are handled

9faff35

Code Review Changes

78cd16d

Code Review Comments

4a40e1e

Supporting both banner and native and sending 0x0 in case of native

a218d43

Bug Fixes

f65b3fb

Bug response not processed by prebid

a717fbc

Change warning message

af2503d

Fixed typo

21277c1

Merge pull request #4 from prebid/master

53ac4fe

Latest

Merge branch 'master' of github.com:pm-shashank-jain/Prebid.js into n…

ac1919f

…ativesupport

Do not send request in case of invalid native bid

1de1623

Do not send request in case of invalid native requests

6b059b7

objects converted to strings in log for debug purposes

9c80c46

Fixed logic to check for required parmas

e0f8763

Fixed typo for stringify

c4ee495

Merge pull request #3 from pm-shashank-jain/nativesupport

d4abb65

changes to support native in pubmaticbid adapter

documentation for native

f143cee

pm-shashank-jain and others added 9 commits December 26, 2018 15:22

Merge pull request #5 from pm-shashank-jain/nativesupport

06a6e34

documentation for native

Review comments from Prebid

84a9c02

Typo

e3d068e

Typo

468c3ab

Updated pub id for native

11fce22

Code Review

b23e2dd

Merge pull request #6 from pm-shashank-jain/nativesupport

6b8c31b

Review comments from Prebid

Merge branch 'master' of https://github.com/pm-shashank-jain/Prebid.js …

137c71c

…into multiformat_support Conflicts: modules/pubmaticBidAdapter.js

changes to support multiformat requests in single imp

9dc4880

pm-harshad-mane suggested changes Jan 17, 2019

View reviewed changes

pm-manasi-moghe and others added 2 commits January 18, 2019 14:21

dded new test cases and changes as per code review comments

8908d88

Merge pull request #7 from pm-manasi-moghe/master

d3ab524

merge master into branch

pm-manasi-moghe closed this Jun 22, 2021

pm-manasi-moghe pushed a commit that referenced this pull request Feb 7, 2023

Merge pull request #5 from prebid/master

7f186df

rebase

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Multiformat support #5

Multiformat support #5

pm-manasi-moghe commented Jan 16, 2019

pm-harshad-mane Jan 17, 2019

pm-manasi-moghe Jan 17, 2019

pm-harshad-mane Jan 17, 2019

pm-manasi-moghe Jan 17, 2019

pm-harshad-mane Jan 17, 2019

pm-manasi-moghe Jan 17, 2019

pm-harshad-mane Jan 17, 2019

pm-manasi-moghe Jan 17, 2019

pm-harshad-mane Jan 17, 2019

pm-manasi-moghe Jan 17, 2019

pm-harshad-mane Jan 17, 2019

pm-harshad-mane Jan 17, 2019

pm-harshad-mane Jan 17, 2019

pm-harshad-mane Jan 17, 2019

pm-harshad-mane Jan 17, 2019

Multiformat support #5

Multiformat support #5

Conversation

pm-manasi-moghe commented Jan 16, 2019

Type of change

Description of change

Other information

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment