Skip to content
This repository has been archived by the owner on Sep 5, 2023. It is now read-only.

rpma: adopt usage_to_access to support iWARP specificity XXX #1029

Closed
wants to merge 1 commit into from

Conversation

janekmi
Copy link

@janekmi janekmi commented Apr 27, 2021

This change is Reviewable

Copy link
Contributor

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 3 files reviewed, 2 unresolved discussions (waiting on @janekmi)


src/mr.c, line 70 at r1 (raw file):

usage_to_access(struct rpma_peer *peer, int usage)

usage_to_access(int usage, struct rpma_peer *peer)

BTW
do we need a whole peer here?
in this case, shall we move usage_to_access to peer_usage_to_access?


src/peer.c, line 158 at r1 (raw file):

 */
enum ibv_transport_type
rpma_peer_get_transport_type(struct rpma_peer *peer)

inline?

Copy link
Contributor

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @janekmi)

@janekmi janekmi force-pushed the rpma-usage_to_access-iWARP branch from b7179c5 to 227b238 Compare April 30, 2021 12:05
Copy link
Author

@janekmi janekmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 3 files reviewed, 2 unresolved discussions (waiting on @grom72)


src/mr.c, line 70 at r1 (raw file):

Previously, grom72 (Tomasz Gromadzki) wrote…
usage_to_access(struct rpma_peer *peer, int usage)

usage_to_access(int usage, struct rpma_peer *peer)

BTW
do we need a whole peer here?
in this case, shall we move usage_to_access to peer_usage_to_access?

Yes. I like the idea. Moved.


src/peer.c, line 158 at r1 (raw file):

Previously, grom72 (Tomasz Gromadzki) wrote…

inline?

Dropped.

@janekmi janekmi force-pushed the rpma-usage_to_access-iWARP branch from 227b238 to 26b2b98 Compare April 30, 2021 12:08
@janekmi janekmi force-pushed the rpma-usage_to_access-iWARP branch from 26b2b98 to 8e77e96 Compare April 30, 2021 12:19
Copy link
Member

@ldorau ldorau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r2.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @grom72)

@janekmi
Copy link
Author

janekmi commented May 5, 2021

Ref: #1044

@janekmi janekmi closed this May 5, 2021
@janekmi janekmi deleted the rpma-usage_to_access-iWARP branch December 30, 2021 23:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants