v5: Add revision history info, drop NEW markers #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjhursey
requested changes
Sep 2, 2022
raffenet
force-pushed
the
v5-for-master
branch
from
864ec60 to
8a2d131
Compare
jjhursey
previously approved these changes
Sep 13, 2022
Signed-off-by: Ken Raffenetti <[email protected]> Co-authored-by: David Solt <[email protected]> Co-authored-by: Joshua Hursey <[email protected]>
After discussion at the 2022 Q3 ASC meeting, it was proposed to remove all "new" markings from declarations. The reasoning behind the proposal: 1. These markings are error prone and not consistently updated when new versions are released. 2. Information on which items are new can be found in the revision history chapter. Signed-off-by: Ken Raffenetti <[email protected]>
raffenet
force-pushed
the
v5-for-master
branch
from
8a2d131 to
3d6890e
Compare
jjhursey
previously approved these changes
Nov 8, 2022
|
This LGTM. I think if @dsolt is good with it then we can merge whenever you are ready. |
dsolt
previously approved these changes
Nov 21, 2022
Signed-off-by: Ken Raffenetti <[email protected]>
Signed-off-by: Ken Raffenetti <[email protected]>
Signed-off-by: Ken Raffenetti <[email protected]>
raffenet
force-pushed
the
v5-for-master
branch
from
2b4edf2 to
c1c35b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains 2 commits.