Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change type of key parameter to PMIx_Get_nb to match PMIx_get #488

Merged
merged 2 commits into from
Jan 25, 2024
Merged

Change type of key parameter to PMIx_Get_nb to match PMIx_get #488

merged 2 commits into from
Jan 25, 2024

Conversation

abouteiller
Copy link
Contributor

Change type of key parameter to PMIx_Get_nb to match PMIx_get (i.e., pmix_key_t)

@abouteiller abouteiller self-assigned this Jun 7, 2023
@abouteiller abouteiller added this to the PMIx v4.2 Standard milestone Jun 7, 2023
@abouteiller abouteiller linked an issue Jun 7, 2023 that may be closed by this pull request
Parameter Conflict: PMIx_Get vs PMIx_Get_nb #420
Closed
@jjhursey jjhursey added the Eligible Eligible for consideration by ASC label Jul 3, 2023
@jjhursey
Copy link
Member

PMIx ASC 3Q 2023 Voting results:

  • Yes: 6
  • No: 0
  • Abstain: 0
  • Result: Pass as Errata. Can be merged at the discretion of Co-Chairs/RMs.

@jjhursey jjhursey added the First Vote Passed ASC first vote passed label Jul 20, 2023
jjhursey
jjhursey previously approved these changes Sep 14, 2023
View reviewed changes
@jjhursey
Copy link
Member

This branch needs to be rebased to resolve the conflict. Then it is ready to go. Thanks!

@abouteiller abouteiller force-pushed the issue420/get_nb_key@v4 branch from f6dc2ad to 0cc35b3 Compare January 11, 2024 10:33
@abouteiller abouteiller requested a review from jjhursey January 11, 2024 10:34
@abouteiller abouteiller mentioned this pull request Jan 11, 2024
Merged
3 tasks
@abouteiller abouteiller merged commit 70655d2 into pmix:v4 Jan 25, 2024
1 check passed
This was referenced Apr 12, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjhursey jjhursey Awaiting requested review from jjhursey

Assignees

@abouteiller abouteiller

Labels
Eligible Eligible for consideration by ASC Errata First Vote Passed ASC first vote passed
Projects
None yet
Milestone
PMIx v4.2 Standard
Development

Successfully merging this pull request may close these issues.

Parameter Conflict: PMIx_Get vs PMIx_Get_nb
2 participants
@abouteiller @jjhursey