fix type

pmndrs · Jan 5, 2025 · a0402eb · a0402eb
1 parent 2f26b07
commit a0402eb
Showing 1 changed file with 17 additions and 16 deletions.
diff --git a/tests/vanilla/effect.test.ts b/tests/vanilla/effect.test.ts
@@ -16,7 +16,7 @@ type Ref = {
   inProgress: number
   isRefreshing: number
   epoch: number
-  cleanup?: Cleanup | void
+  cleanup?: Cleanup | undefined
   error?: unknown
 }
 
@@ -52,21 +52,22 @@ function syncEffect(effect: Effect): Atom<void> {
       try {
         ref.cleanup?.()
         const deps = new Set<AnyAtom>()
-        ref.cleanup = effect(
-          (a) => {
-            deps.add(a)
-            return ref.get!(a)
-          },
-          (a, ...args) => {
-            try {
-              ++ref.inProgress
-              return store.set(a, ...args)
-            } finally {
-              deps.forEach(ref.get!)
-              --ref.inProgress
-            }
-          },
-        )
+        ref.cleanup =
+          effect(
+            (a) => {
+              deps.add(a)
+              return ref.get!(a)
+            },
+            (a, ...args) => {
+              try {
+                ++ref.inProgress
+                return store.set(a, ...args)
+              } finally {
+                deps.forEach(ref.get!)
+                --ref.inProgress
+              }
+            },
+          ) || undefined
       } catch (e) {
         ref.error = e
         // FIXME no test case that requires this refreshing