Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Update examples for Immer and Valtio #2172

Merged
merged 3 commits into from
Oct 11, 2023

Conversation

dmaskasky
Copy link
Collaborator

Related Issues or Discussions

Resolves: #2171

Summary

Update the inline and codesandbox examples for Immer and Valtio to more accurately and clearly showcase their functionalities.

Check List

  • yarn run prettier for formatting code and docs

@vercel
Copy link

vercel bot commented Oct 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
jotai ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 11, 2023 11:03pm

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 11, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2d7edc3:

Sandbox Source
React Configuration
React TypeScript Configuration
React Browserify Configuration
React Snowpack Configuration
Next.js Configuration
Next.js with custom Babel config Configuration
React with custom Babel config Configuration

Copy link
Member

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on the improvements. Some suggestions.

docs/integrations/immer.mdx Show resolved Hide resolved
docs/integrations/immer.mdx Show resolved Hide resolved
docs/integrations/immer.mdx Show resolved Hide resolved
docs/integrations/immer.mdx Show resolved Hide resolved
docs/integrations/valtio.mdx Outdated Show resolved Hide resolved
docs/integrations/valtio.mdx Show resolved Hide resolved
docs/integrations/valtio.mdx Show resolved Hide resolved
Update the inline and codesandbox examples for Immer and Valtio to more accurately and clearly showcase their functionalities.
Copy link
Member

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for my misunderstanding. This should be good. Thanks for your contribution.

@dai-shi dai-shi merged commit 3e5fda0 into pmndrs:main Oct 11, 2023
30 checks passed
@dmaskasky dmaskasky deleted the docs-immer-and-valtio branch October 11, 2023 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants