Eslint config #228
Merged
Eslint config #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've configured @typescript-eslint, extended few defaults and compatibility rule configs which disable rules redundant in TS. ```json { "overrides": [ { "files": ["*.ts", "*.tsx"], "parser": "@typescript-eslint/parser", "plugins": ["@typescript-eslint"], "parserOptions": { "ecmaFeatures": { "jsx": true }, "ecmaVersion": 2018, "project": "./tsconfig.json", "sourceType": "module" }, "extends": [ "plugin:@typescript-eslint/recommended", "plugin:@typescript-eslint/eslint-recommended", "prettier/@typescript-eslint" ], "rules": { "import/no-unresolved": "off", "no-useless-constructor": "off", "@typescript-eslint/no-useless-constructor": "error", "@typescript-eslint/no-namespace": "off", "@typescript-eslint/no-explicit-any": "off", "@typescript-eslint/no-use-before-define": "off", "@typescript-eslint/no-parameter-properties": "off", "@typescript-eslint/no-unused-vars": ["warn", { "argsIgnorePattern": "^_", "varsIgnorePattern": "^_" }], "@typescript-eslint/explicit-function-return-type": "off", } } ] } ``` I've added two entries below to decrease the number of ESLint violations to 15. They are not "errors" and won't lead to a bug so there's probably no use to bother with them ATM. ``` "@typescript-eslint/no-inferrable-types": "warn", "@typescript-eslint/no-empty-function": "off" ```
|
what happens when you do --fix? does it ... fix it? 😇 |
Some of the rules have an autofix implemented and though I believe only autofixes that don't change behavior are included, but I'm not really comfortable with the codebase yet and I didn't PR a feature nor a big bugfix, so I'm not sure if it would be polite to run autofixes on your code and tell you what keyword to use when declaring variables. I don't really care much for ESLint's consistency rules personally, prefering bug or mistake detection rules, but I wanted error squiggles to go away 🙈 and there was a |
|
I described some of the changes in the commit message a4e7002. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there 👋
I'm fiddling around #172 and I've noticed few problems with ESLint config in the repo (it doesn't parse TS files, eslint script in package.json doesn't run etc.)
I've extended few defaults and compatibility rule configs (which disable rules redundant in TS) and made them a little bit less strict.
yarn eslintnow printswhich are mostly
no-unused-varsandreact-hooks/exhaustive-depsI'm kinda afraid of running
--fix.