Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(*): replace 'pnpm <command>' with 'pnpm run <command>' #2991

Merged
merged 2 commits into from
Feb 4, 2025

Conversation

sukvvon
Copy link
Contributor

@sukvvon sukvvon commented Feb 3, 2025

Summary

Changes

  • We agreed to avoid using aliases.
  • Replaced pnpm <command> with pnpm run <command> for all related commands.
  • Explicitly added run to avoid potential conflicts with pnpm's lifecycle commands, as omitting run can cause conflicts.
  • This change was made to maintain consistency with existing commands that already use the pnpm run <command> format.

Reason

  • Adding run ensures that commands are clearly separated from pnpm's lifecycle commands, preventing conflicts.
  • Using pnpm run helps clarify the intention of running a script.
  • This change aligns with the existing usage of pnpm run, maintaining consistency across the codebase.

Check List

  • pnpm run fix:format for formatting code and docs

Copy link

vercel bot commented Feb 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
zustand-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 4, 2025 10:50am

Copy link

codesandbox-ci bot commented Feb 3, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

pkg-pr-new bot commented Feb 3, 2025

Open in Stackblitzdemostarter

npm i https://pkg.pr.new/zustand@2991

commit: 08e643e

Copy link
Member

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Please send PRs to other two repos.

@dai-shi dai-shi merged commit 49ee631 into pmndrs:main Feb 4, 2025
28 checks passed
@dai-shi
Copy link
Member

dai-shi commented Feb 4, 2025

Thanks as always!

@sukvvon sukvvon deleted the chore/add-run-in-pnpm-script branch February 4, 2025 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants