-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(middleware): add persist api #624
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit dd698f4:
|
Size Change: +498 B (+5%) 🔍 Total Size: 11.1 kB
ℹ️ View Unchanged
|
8f14782
to
dc433ed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks overall good. Some minor things and typing issues need to be addressed.
dc433ed
to
d063bf0
Compare
Within the tests, the immer middleware keep the zustand/tests/middlewareTypes.test.tsx Line 477 in d063bf0
There's still another minor type issue within the middleware with the |
Yeah, I can't think of other ways.
Hm, I don't know either. Let's add type assertion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good.
Closes #267, #513