Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(middleware/devtools): deprecate passing name directly instead of an object #731

Merged
merged 1 commit into from
Dec 24, 2021
Merged

fix(middleware/devtools): deprecate passing name directly instead of an object #731

merged 1 commit into from
Dec 24, 2021

Conversation

devanshj
Copy link
Contributor

@devanshj devanshj commented Dec 24, 2021 •
edited
Loading

From #715:

  • devtools({}, name) to devtools({}, { name }. Ability to pass the name directly is a rather unnecessary feature, more over expecting an object is consistent with persist. Good part is the documentation doesn't mention that you can directly pass the name so hopefully many users would not be using it.

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9b5cf00:

Sandbox Source
React Configuration
React Typescript Configuration
React Browserify Configuration
React Snowpack Configuration
React Parcel Configuration
Next.js Configuration

@devanshj devanshj mentioned this pull request Dec 24, 2021
Closed
dai-shi
dai-shi approved these changes Dec 24, 2021
View reviewed changes
Copy link
Member

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dai-shi dai-shi added this to the v3.6.8 milestone Dec 24, 2021
@dai-shi dai-shi changed the title devtools: deprecate passing name directly instead of an object fix(middieware/devtools): deprecate passing name directly instead of an object Dec 24, 2021
@devanshj devanshj changed the title fix(middieware/devtools): deprecate passing name directly instead of an object fix(middleware/devtools): deprecate passing name directly instead of an object Dec 24, 2021
@dai-shi dai-shi merged commit 2ddbd76 into pmndrs:main Dec 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dai-shi dai-shi dai-shi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.6.8
Development

Successfully merging this pull request may close these issues.
2 participants
@devanshj @dai-shi